Don't use a string as the OpenAPI default value for Helm values with an empty object default #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcapizzi
force-pushed
the
fix-empty-obj-default
branch
2 times, most recently
from
190bfff to
014119b
Compare
gcapizzi
force-pushed
the
fix-empty-obj-default
branch
from
014119b to
62db2f6
Compare
…an empty object default
This fixes the translation of empty object Helm default values into
OpenAPI. Empty objects were getting the string `"{}"` as their default,
which is not a valid value. We now correctly use `{}`.
Signed-off-by: Giuseppe Capizzi <[email protected]>
gcapizzi
force-pushed
the
fix-empty-obj-default
branch
from
62db2f6 to
a0b9617
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes the translation of empty object Helm default values into OpenAPI. Empty objects were getting the string
"{}"as their default, which is not a valid value. We now correctly use{}.Which issue(s) this PR fixes:
Fixes #1448
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
Relevant docs in this repo added or updatedRelevant carvel.dev docs added or updated in a separate PR and there's a link to that PR