Updating docs for response header #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Barbato <[email protected]>
✅ Deploy Preview for carvel canceled.
|
|
Please let me know if I need to fix anything here @joaopapereira! Thanks :) |
| @@ -116,6 +116,8 @@ directories: | |||
| name: my-image-auth | |||
| # specify wether to skip TLS verification; defaults to false (optional;v0.18.0+) | |||
| dangerousSkipTLSVerify: false | |||
| # specify the response timeout in seconds for imgpkg when querying the registry; defaults to 30 (optional; v0.40.0+) | |||
| dangerousSkipTLSVerify: 30 | |||
There was a problem hiding this comment.
Is this the correct variable name?
There was a problem hiding this comment.
Variable should be ResponseHeaderTimeout ?
There was a problem hiding this comment.
yeah that's embarrassing. Sorry about that and it's updated now!
praveenrewar
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
LGTM! Thank you!
@alexbarbato It seems the DCO bot is not happy (yet again 😄 ). Could you sign your last commit as well.
Signed-off-by: Alex Barbato <[email protected]>
alexbarbato
force-pushed
the
vendir-docs-update-response-header
branch
from
1cc8c14 to
bc3b98c
Compare
|
I swear I did it this time @praveenrewar! Just clearly... I didn't.... Thanks and updated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
carvel-dev/vendir#344
Updating docs for this PR.
I totally guessed on which version of vendir this would be included in so definitely can update that.