You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey
How do i build this from github?
I cargo build on the repo locally and it works, but when i add it to my project like so:
icondata = {git="https://github.com/carloskiki/icondata.git"}
it fails like this:
error: invalid character { in package name: icondata_{{short_name}}, characters must be Unicode XID characters (numbers, -, _, or most letters)
--> .........cargo\git\checkouts\icondata-5d3f02090c1ec0c4\cc7de05\build\templates\icon_lib\Cargo.toml:2:8
|
2 | name = "icondata_{{short_name}}"
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
error: invalid key
--> .........cargo\git\checkouts\icondata-5d3f02090c1ec0c4\cc7de05\build\templates\main_lib\Cargo.toml:17:1
|
17 | {% for (short_name, version) in short_name_version -%}
| ^
|
I tried looking up a few threads on this, but nothing suggested worked
The text was updated successfully, but these errors were encountered:
This happens because we use a build script to generate the different crates when upstream icon libraries update, and git dependencies don't seem to differentiate between workspace members and arbitrary packages. One way we could solve this is to rename the templates from Cargo.toml to Cargo.template.toml or something like that. I don't have time to make the change at the moment however so you would have to submit a PR.
Another alternative would be to clone the repository & use path dependencies instead.
Hey
How do i build this from github?
I cargo build on the repo locally and it works, but when i add it to my project like so:
icondata = {git="https://github.com/carloskiki/icondata.git"}
it fails like this:
error: invalid character
{
in package name:icondata_{{short_name}}
, characters must be Unicode XID characters (numbers,-
,_
, or most letters)--> .........cargo\git\checkouts\icondata-5d3f02090c1ec0c4\cc7de05\build\templates\icon_lib\Cargo.toml:2:8
|
2 | name = "icondata_{{short_name}}"
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
error: invalid key
--> .........cargo\git\checkouts\icondata-5d3f02090c1ec0c4\cc7de05\build\templates\main_lib\Cargo.toml:17:1
|
17 | {% for (short_name, version) in short_name_version -%}
| ^
|
I tried looking up a few threads on this, but nothing suggested worked
The text was updated successfully, but these errors were encountered: