-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiline message support #150
Comments
how about, just like when we used to send emails from the command line, when finished with your message you enter a single dot on it's own line
the final carriage return after the dot proceeds to the next gitmoji section. retro and elegant. |
@silent-e that could be nice, but how should it work if one pastes some text? I came here because in my case I already had the (long) commit message written somewhere. My use case was me trying to |
Ran into a similar need for multiline commit messages. Here are options I have been exploring to add to
I have started building 1-3 allowing for configurability. I will open a PR in the next few days once I have something working. |
Ideally we should implement the multiline support through inquirer, even If they still don't support it, basically to avoid doing hacky things 😄 |
👍 I don't plan to go the hacky route. It was more an exercise in a quick solution locally so I can use it with multiline commits.
Initially I thought we would need to get multiline support into inquirer. They allow for custom prompts that we can register at runtime. I am going to build a prompt that works with inquirer as multiline and see if I run into any issues. I'd like to support:
I did some research on the external editor support with |
support |
make the behavior configurable, both as a default in the config file, but also an overriding flag. ImplementationIf you pass Look at the To maintain backwards compatibility, without flags, support single line messages (kind of like Users can create bash aliases, or change the configuration to support a default behavior if they wish. Note, that if the default behavior can be set to |
This comment has been minimized.
This comment has been minimized.
I support this suggestion, but for making it more intuitive, keep asking for a message until a blank string is submitted. |
Hello @carloscuesta!
Issue:
Multiline message do not seem to be supported
ubuntu 18.04:
gitmoji-cli 1.9.2:
node 10.14:
Awesome module!
It would be great if multiline messages were supported!
The text was updated successfully, but these errors were encountered: