Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleClick GUI improvements #373

Closed
stickgrinder opened this issue Jan 1, 2025 · 1 comment
Closed

SimpleClick GUI improvements #373

stickgrinder opened this issue Jan 1, 2025 · 1 comment
Assignees
Labels
improvement New feature or request
Milestone

Comments

@stickgrinder
Copy link
Collaborator

stickgrinder commented Jan 1, 2025

Dependencies

This issue precedes #374

Benefit description

Papernoise suggested a different take for the SimpleClick GUI, which brings us further away from the original PowerHoof-inspired one and addresses some usability issues of that approach.

With these improvements, Popochiu will provide a fresh and personal take on this modern paradigm of interaction.

Solution description

Please take a look at Papernoise's proposal below.

Image

In this design, the SimpleClick interface should only have one bar (which can be fixed or auto-hiding as in the current version).
This bar will hold the inventory, and the settings/tools bar will be moved to a popup triggered by a button.

The button can be held by the inventory bar or separated (to make more inventory components available for the SC GUI - think about the Deponia folding one, for example).

Once open, the popup will be organized more or less like this:

Image

With actions and settings separated into two different columns.

This would make the UI feel and appear cleaner and more polished and avoid graphical weirdness in games with many inventory items.

Keeping the menu button and the inventory bar separate in terms of components will allow for more modularization (see TBD).

Exclusions

Despite the high-res mockups provided by PaperNoise, this issue is relative to the current available GUI.

Implications

Upgrading this template GUI will affect games currently under development.
We should map with great attention every possible change to the components API and functions, in case the components instances in the game folder call some engine-held code.

@stickgrinder stickgrinder added the improvement New feature or request label Jan 1, 2025
@stickgrinder stickgrinder moved this to Ready in Popochiu Jan 1, 2025
mapedorr added a commit that referenced this issue Jan 5, 2025
These components will replace the old InventoryBar and SettingsBar as
part of the update for the SimpleClickGUI as proposed be Papernoise.
mapedorr added a commit that referenced this issue Jan 5, 2025
…ent.

Now devs can set if the Sound Volumens component should show the Master
bus only and if it should show the label with the name for each bus.

- **upd** Add custom icons for radio buttons in PopupMenu for the
  base_gui_theme.tres.
mapedorr added a commit that referenced this issue Jan 5, 2025
Players can now open the save, load, history and quit popups. They can
also change volumes, the text continue mode and the text speed.
mapedorr added a commit that referenced this issue Jan 5, 2025
…ent.

Now devs can set if the Sound Volumens component should show the Master
bus only and if it should show the label with the name for each bus.

- **upd** Add custom icons for radio buttons in PopupMenu for the
  base_gui_theme.tres.
mapedorr added a commit that referenced this issue Jan 6, 2025
This component uses a CheckButton with two labels so players can have
a better understanding of the current dialogue advancement mode.
mapedorr added a commit that referenced this issue Jan 7, 2025
This also updates the behavior of the cursor when hovering the settings
button (to be improved).
@mapedorr mapedorr moved this from Ready to In progress in Popochiu Jan 7, 2025
mapedorr added a commit that referenced this issue Jan 10, 2025
These components will replace the old InventoryBar and SettingsBar as
part of the update for the SimpleClickGUI as proposed be Papernoise.
mapedorr added a commit that referenced this issue Jan 10, 2025
Players can now open the save, load, history and quit popups. They can
also change volumes, the text continue mode and the text speed.
mapedorr added a commit that referenced this issue Jan 10, 2025
…ent.

Now devs can set if the Sound Volumens component should show the Master
bus only and if it should show the label with the name for each bus.

- **upd** Add custom icons for radio buttons in PopupMenu for the
  base_gui_theme.tres.
mapedorr added a commit that referenced this issue Jan 10, 2025
This component uses a CheckButton with two labels so players can have
a better understanding of the current dialogue advancement mode.
mapedorr added a commit that referenced this issue Jan 10, 2025
This also updates the behavior of the cursor when hovering the settings
button (to be improved).
mapedorr added a commit that referenced this issue Jan 11, 2025
The script is executed only if the project is using the SimpleClick
template, and it removes the InventoryBar, SettingsBar,
TextSettingsPopup and SoundSettingsPopup components.
mapedorr added a commit that referenced this issue Jan 12, 2025
…he SaveAndLoadPopup.

The new Simple Click GUI uses the SimpleClickBar and the
SimpleClickPopup components. Instead of adding a new migration step, the
SaveAndLoadPopup is also removed in the first step and then added in the
second one.

- **upd** Remove the `@onready` vars in the Simple Click GUI to access
  the SaveAndLoadPopup, HistoryPopup, and QuitPopup since it is no
  longer used to open those popups.
mapedorr added a commit that referenced this issue Jan 17, 2025
These components will replace the old InventoryBar and SettingsBar as
part of the update for the SimpleClickGUI as proposed be Papernoise.
mapedorr added a commit that referenced this issue Jan 17, 2025
Players can now open the save, load, history and quit popups. They can
also change volumes, the text continue mode and the text speed.
mapedorr added a commit that referenced this issue Jan 17, 2025
…ent.

Now devs can set if the Sound Volumens component should show the Master
bus only and if it should show the label with the name for each bus.

- **upd** Add custom icons for radio buttons in PopupMenu for the
  base_gui_theme.tres.
mapedorr added a commit that referenced this issue Jan 17, 2025
This component uses a CheckButton with two labels so players can have
a better understanding of the current dialogue advancement mode.
mapedorr added a commit that referenced this issue Jan 17, 2025
This also updates the behavior of the cursor when hovering the settings
button (to be improved).
mapedorr added a commit that referenced this issue Jan 17, 2025
The script is executed only if the project is using the SimpleClick
template, and it removes the InventoryBar, SettingsBar,
TextSettingsPopup and SoundSettingsPopup components.
mapedorr added a commit that referenced this issue Jan 17, 2025
…he SaveAndLoadPopup.

The new Simple Click GUI uses the SimpleClickBar and the
SimpleClickPopup components. Instead of adding a new migration step, the
SaveAndLoadPopup is also removed in the first step and then added in the
second one.

- **upd** Remove the `@onready` vars in the Simple Click GUI to access
  the SaveAndLoadPopup, HistoryPopup, and QuitPopup since it is no
  longer used to open those popups.
mapedorr added a commit that referenced this issue Jan 21, 2025
Instead of this, the popup's main script is updated with the content
of the one in the addons folder.
mapedorr added a commit that referenced this issue Jan 22, 2025
…ory.

- **fix**: Assign unique names to the **Up** and **Down** icons in the
  base **InventoryGrid** component.
mapedorr added a commit that referenced this issue Feb 4, 2025
mapedorr added a commit that referenced this issue Feb 4, 2025
These components will replace the old InventoryBar and SettingsBar as
part of the update for the SimpleClickGUI as proposed be Papernoise.
mapedorr added a commit that referenced this issue Feb 4, 2025
Players can now open the save, load, history and quit popups. They can
also change volumes, the text continue mode and the text speed.
mapedorr added a commit that referenced this issue Feb 4, 2025
…ent.

Now devs can set if the Sound Volumens component should show the Master
bus only and if it should show the label with the name for each bus.

- **upd** Add custom icons for radio buttons in PopupMenu for the
  base_gui_theme.tres.
mapedorr added a commit that referenced this issue Feb 4, 2025
This component uses a CheckButton with two labels so players can have
a better understanding of the current dialogue advancement mode.
mapedorr added a commit that referenced this issue Feb 4, 2025
This also updates the behavior of the cursor when hovering the settings
button (to be improved).
mapedorr added a commit that referenced this issue Feb 4, 2025
The script is executed only if the project is using the SimpleClick
template, and it removes the InventoryBar, SettingsBar,
TextSettingsPopup and SoundSettingsPopup components.
mapedorr added a commit that referenced this issue Feb 4, 2025
…he SaveAndLoadPopup.

The new Simple Click GUI uses the SimpleClickBar and the
SimpleClickPopup components. Instead of adding a new migration step, the
SaveAndLoadPopup is also removed in the first step and then added in the
second one.

- **upd** Remove the `@onready` vars in the Simple Click GUI to access
  the SaveAndLoadPopup, HistoryPopup, and QuitPopup since it is no
  longer used to open those popups.
mapedorr added a commit that referenced this issue Feb 4, 2025
Instead of this, the popup's main script is updated with the content
of the one in the addons folder.
mapedorr added a commit that referenced this issue Feb 4, 2025
…ory.

- **fix**: Assign unique names to the **Up** and **Down** icons in the
  base **InventoryGrid** component.
mapedorr added a commit that referenced this issue Feb 4, 2025
mapedorr added a commit that referenced this issue Feb 5, 2025
- **upd** Reassign the texture used by the **AtlasTexture** of all the
  icons in the **SimpleClickSettingsPopup** to use the
  `simple_click_settings_popup_icons.png` instead of a
  CompressedTexture2D.
mapedorr added a commit that referenced this issue Feb 14, 2025
* refs #373: Create bar and settings popup for the SimpleClickGUI.

These components will replace the old InventoryBar and SettingsBar as
part of the update for the SimpleClickGUI as proposed be Papernoise.

* refs #373: Make buttons and other components usable.

Players can now open the save, load, history and quit popups. They can
also change volumes, the text continue mode and the text speed.

* refs #373: Update icons and add setup options to Sound Volumes component.

Now devs can set if the Sound Volumens component should show the Master
bus only and if it should show the label with the name for each bus.

- **upd** Add custom icons for radio buttons in PopupMenu for the
  base_gui_theme.tres.

* refs #373: Create DialogueAdvancement component with better feedback.

This component uses a CheckButton with two labels so players can have
a better understanding of the current dialogue advancement mode.

* refs #373: Remove non used components and popups in SimpleClick GUI.

This also updates the behavior of the cursor when hovering the settings
button (to be improved).

* refs #373: Progress on migration script to update the SimpleClick GUI.

The script is executed only if the project is using the SimpleClick
template, and it removes the InventoryBar, SettingsBar,
TextSettingsPopup and SoundSettingsPopup components.

* refs #373: Update migration script to add new components and update the SaveAndLoadPopup.

The new Simple Click GUI uses the SimpleClickBar and the
SimpleClickPopup components. Instead of adding a new migration step, the
SaveAndLoadPopup is also removed in the first step and then added in the
second one.

- **upd** Remove the `@onready` vars in the Simple Click GUI to access
  the SaveAndLoadPopup, HistoryPopup, and QuitPopup since it is no
  longer used to open those popups.

* refs #373: Update migration to avoid removing the SaveAndLoadPopup

Instead of this, the popup's main script is updated with the content
of the one in the addons folder.

* refs #373: Remove commented code and improve saving

* refs #373: Improve and homogenize icon sizing when items enter inventory.

- **fix**: Assign unique names to the **Up** and **Down** icons in the
  base **InventoryGrid** component.

* refs #373: Improve property value assignation based on review suggestion.

Co-authored-by: Paolo Pustorino <[email protected]>

* refs #373: Make improvements suggested by @stickgrinder on its PR review

- **upd** Reassign the texture used by the **AtlasTexture** of all the
  icons in the **SimpleClickSettingsPopup** to use the
  `simple_click_settings_popup_icons.png` instead of a
  CompressedTexture2D.

* refs #373: Update SimpleClickSettingsPopup icons based on PR feedback.

---------

Co-authored-by: Paolo Pustorino <[email protected]>
@mapedorr
Copy link
Collaborator

Closed with #379 .

@mapedorr mapedorr moved this from In progress to Done in Popochiu Feb 14, 2025
@mapedorr mapedorr added this to the v2.1 - Stable milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants