Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the way walk_to_point and look_at_point are used by client code #316

Open
stickgrinder opened this issue Oct 26, 2024 · 1 comment
Labels
improvement New feature or request

Comments

@stickgrinder
Copy link
Collaborator

Description

Working on #233 we noticed that both walk_to_point and look_at_point need to be transformed to global coordinate during game execution.

Formerly a getter was present, to return the local or global coordinates of those points depeing on the execution context (in editor or in game), but that remnant was creating more harm than good and the function was unused.

Now the calling code globalize the positions in its own way, providing defaults as needed. We can make things more coherent if we create two specific methods the client code can call from the clickable to get the global positions of those coordinates, maybe with sensible fallback defaults.

@stickgrinder stickgrinder added the improvement New feature or request label Oct 26, 2024
@stickgrinder stickgrinder moved this to Backlog in Popochiu Oct 26, 2024
@stickgrinder
Copy link
Collaborator Author

Mentioning @drbbgh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant