Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log verbosity #5016

Open
Melraidin opened this issue Feb 28, 2025 · 2 comments · May be fixed by #5022
Open

Reduce log verbosity #5016

Melraidin opened this issue Feb 28, 2025 · 2 comments · May be fixed by #5022
Labels
Improvement Mark a PR as an improvement, for auto-generated CHANGELOG Operations

Comments

@Melraidin
Copy link

Melraidin commented Feb 28, 2025

Why?

Currently cardano-wallet logs every wallet it's tracking for at least some requests. This causes a great deal of noise in the logs when recording at the "info" level.

Over a one minute span cardano-wallet was hit with 976 requests to get transactions for various wallets. Each of those requests caused 114 lines to logged recording each wallet that cardano-wallet is tracking, plus two lines for recording the request itself. This made 62 887 lines recording wallets' existence of the total 64 700 lines logged over that one minute. For every two lines recording a request (the start and end of the request) we're seeing 114 lines that don't provide useful information, or 13 MB of noise for every 450 KB of data. This ratio is only expected to get worse as the number of wallets being tracked increases.

What?

Can logging which wallets were found, and any other information mainly of interest to cardano-wallet developers, be moved to the "debug" log level? In general I don't think this information is useful to operators simply running cardano-wallet.

How?

No response

@abailly abailly added Improvement Mark a PR as an improvement, for auto-generated CHANGELOG Operations labels Mar 4, 2025
@abailly
Copy link
Collaborator

abailly commented Mar 4, 2025

As mentioned by @paolino while it's pretty easy to change the level of the logs, it's unclear what's the right level for everything.
For the case of Found existing wallet: messages we are toning it down to Debug level which should already significantly reduce the volume of logs.

As an aside, got some questions: Are you using JSON formatted logs? How do you consume/store/process those logs?

@abailly abailly linked a pull request Mar 4, 2025 that will close this issue
@abailly
Copy link
Collaborator

abailly commented Mar 4, 2025

We have a section on monitoring in the documentation but no section about logging AFAICT. Something we could add @paolino

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Mark a PR as an improvement, for auto-generated CHANGELOG Operations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants