Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate test artifacts from nightly artifacts in the release pipeline #4935

Closed
4 tasks done
Tracked by #4917
paolino opened this issue Jan 10, 2025 · 0 comments · Fixed by #4936
Closed
4 tasks done
Tracked by #4917

Separate test artifacts from nightly artifacts in the release pipeline #4935

paolino opened this issue Jan 10, 2025 · 0 comments · Fixed by #4936
Assignees
@paolino
Labels
CI CI related Improvement Mark a PR as an improvement, for auto-generated CHANGELOG Release

Comments

@paolino
Copy link
Collaborator

paolino commented Jan 10, 2025 •
edited
Loading

Why

ATM, running the release pipeline from not-master branch triggers a subset of steps in the main pipeline.
OTOH the artifacts produced are not reflecting the test operation and they end up polluting the nightly tags which instead should result from the full main pipeline run. The reason for this is that the release itself is only a final set of publishing step over a successful nightly build.

What

  • Fix the nightly group of release steps to actually tag and push to test release, test bump.sh space, test docker image tag.
  • Bump.sh daily space is renamed to nightly
  • New test space is created in bump.sh
  • A token to push to it is stored in the buildkite hooks

Acceptance

When building the release pipeline over a non-master branch:

  • Nightly release is not affected
  • Docker nightly tag is not affected
  • Bump.sh nightly history not affected
  • Bump.sh test is populated
  • Test release is overwritten
  • Test tagged docker image is pushed to dockerhub

Issues

#4917
@paolino paolino added Improvement Mark a PR as an improvement, for auto-generated CHANGELOG CI CI related Release labels Jan 10, 2025
@paolino paolino self-assigned this Jan 10, 2025
@paolino paolino mentioned this issue Jan 10, 2025
Merged
paolino added a commit that referenced this issue Jan 13, 2025
@paolino
Separate test from nightly tag in the assets (#4936)
cb7e56c 
### Changes

- Shrink the windows steps, moving the setup
- Make sure we fail when trying to rewrite cabal versions or release
tags
- Skip unnecessary steps when testing the release pipeline
- Use `TEST_RC` variable in the pushing artifacts steps to respect
nightly and test separation

### Issues

fix #4935 
fix #4895
@paolino paolino mentioned this issue Jan 13, 2025
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paolino paolino

Labels
CI CI related Improvement Mark a PR as an improvement, for auto-generated CHANGELOG Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Separate test from nightly tag in the assets cardano-foundation/cardano-wallet
1 participant
@paolino