Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the Mauch et al. primary beam correction for mosaicing and primary beam correction #1180

Closed
gigjozsa opened this issue Jun 19, 2020 · 7 comments

Comments

@gigjozsa
Copy link
Collaborator

@bnamumba found a significant difference between total HI fluxes of HIPASS sources and total HI fluxes of galaxies detected in a MeerKAT observation and primary-beam corrected using our standard Gaussian. We had a look and the difference might well be due to the fact that the Gaussian is significantly narrower than the Mauch et al. 2019 primary beam found to be more accurate for the MeerKAT primary beam. Therefore, could we implement:

fwhm = 8.783e10/(60.*nu)

            fwhm.resize((basedata.shape[0], 1, 1))
            theta = np.sqrt(datacube)
            # a = (np.cos(1.189*np.pi*(theta/FWHM))/(1-4*(1.189*(theta/FWHM))**2))**2
            datacube = pow((pow(np.cos(1.189*np.pi*(theta/fwhm))/(1-4*pow(1.189*(theta/fwhm),2)),2))/rmsbeam[i],2)

@paoloserra
Copy link
Collaborator

@gigjozsa Thanks for taking care of this. Could you please implement it in such a way that we have either a telescope option (e.g., MeerKAT, VLA), or a function option (e.g. gauss, mauch)?

@svw26
Copy link
Collaborator

svw26 commented Jun 19, 2020

👍 'Gaussian' and 'Mauchian' sounds good to me...! x

@gigjozsa
Copy link
Collaborator Author

Mauchian, that's great. The cos^6 of WSRT would be a "Brouwian"

@dane-kleiner
Copy link
Collaborator

Hey @gigjozsa, @paoloserra and I have decided that we need to use the Mauchian primary beam model for our paper, so unless you're (almost) ready to commit the changes, I'm happy to make and implement the changes myself.

@gigjozsa
Copy link
Collaborator Author

@dane-kleiner thank you, please go ahead, I am myself currently busy with #779 in the same context.

@dane-kleiner dane-kleiner self-assigned this Jul 20, 2020
@dane-kleiner
Copy link
Collaborator

@paoloserra, please have a look at the mauchian branch to see if we can figure out those anomalous pixels before creating a PR.

@dane-kleiner dane-kleiner mentioned this issue Jul 27, 2020
@paoloserra
Copy link
Collaborator

#1215 should have closed this. Mauch et al. (2020) PB now available both in the line and mosaic workers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants