Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: apply ord document validator in CICD pipeline #65

Open
zongqichen opened this issue Oct 4, 2024 · 4 comments
Open

Feat: apply ord document validator in CICD pipeline #65

zongqichen opened this issue Oct 4, 2024 · 4 comments
Labels

Comments

@zongqichen
Copy link
Contributor

zongqichen commented Oct 4, 2024

At the moment, we only have unittest to protect the result of ord default content generation. However, we need to validate the correctness of ord content by validator.

@zongqichen zongqichen added the good first issue Good for newcomers label Oct 4, 2024
@Fannon
Copy link
Contributor

Fannon commented Oct 7, 2024

In some other projects, I added the API Metadata Validator as an NPM dependency. Then you can call the validator programmatically (not as CLI) in your unit-tests. This will give you a better, integrated testing experience.

@zongqichen
Copy link
Contributor Author

We also need to solve: #63 (comment)

@aramovic79
Copy link
Member

In some other projects, I added the API Metadata Validator as an NPM dependency. Then you can call the validator programmatically (not as CLI) in your unit-tests. This will give you a better, integrated testing experience.

I remember that the recommended way of running the MetadataValidator was by using docker image.
Public Artifactory: cpa-docker.common.repositories.cloud.sap/api-metadata-validator:latest
Internal Artifactory: cpa-docker.cpa-docker.int.repositories.cloud.sap/api-metadata-validator:latest

Has the recommendation being changed meanwhile?
I think we should decide which way is more reliable(and faster also): to run Jest tests by using, as you wrote, API Metadata Validator package or by running API Metadata Validator docker image.

@swennemers
Copy link
Contributor

waiting for open source release of api metadata validator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants