From b8ce92e5a9e48507c69f8690a2e0126671a40bee Mon Sep 17 00:00:00 2001
From: Daniel Hutzel <daniel.hutzel@sap.com>
Date: Mon, 7 Oct 2024 09:57:50 +0200
Subject: [PATCH] chore: remove questionable test

---
 test/tests/error-handling-dev.test.js | 57 ++++++++++++++-------------
 1 file changed, 29 insertions(+), 28 deletions(-)

diff --git a/test/tests/error-handling-dev.test.js b/test/tests/error-handling-dev.test.js
index 87f3184..9e9dcf3 100644
--- a/test/tests/error-handling-dev.test.js
+++ b/test/tests/error-handling-dev.test.js
@@ -453,33 +453,34 @@ describe('graphql - error handling in development', () => {
       expect(response.data.errors[0].extensions.stacktrace).not.toHaveLength(0) // Stacktrace exists and is not empty
     })
 
-    test('req.reject with custom code', async () => {
-      const query = gql`
-        mutation {
-          CustomHandlerErrorsService {
-            Orders {
-              create(input: { id: 3, quantity: 20, stock: 10 }) {
-                id
-                quantity
-                stock
-              }
-            }
-          }
-        }
-      `
-      const errors = [
-        {
-          message: 'The order of NULL books exceeds the stock by NULL',
-          extensions: {
-            code: '500',
-            numericSeverity: 4,
-            stacktrace: expect.any(Array)
-          }
-        }
-      ]
-      const response = await POST('/graphql', { query })
-      expect(response.data).toMatchObject({ errors })
-      expect(response.data.errors[0].extensions.stacktrace).not.toHaveLength(0) // Stacktrace exists and is not empty
-    })
+    // NOTE: Never do such tests: it doesn't check expected behavior but just documents actual one which can change
+    // test('req.reject with custom code', async () => {
+    //   const query = gql`
+    //     mutation {
+    //       CustomHandlerErrorsService {
+    //         Orders {
+    //           create(input: { id: 3, quantity: 20, stock: 10 }) {
+    //             id
+    //             quantity
+    //             stock
+    //           }
+    //         }
+    //       }
+    //     }
+    //   `
+    //   const errors = [
+    //     {
+    //       message: 'The order of NULL books exceeds the stock by NULL',
+    //       extensions: {
+    //         code: '500',
+    //         numericSeverity: 4,
+    //         stacktrace: expect.any(Array)
+    //       }
+    //     }
+    //   ]
+    //   const response = await POST('/graphql', { query })
+    //   expect(response.data).toMatchObject({ errors })
+    //   expect(response.data.errors[0].extensions.stacktrace).not.toHaveLength(0) // Stacktrace exists and is not empty
+    // })
   })
 })