Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a batch get for the metakb API #290

Closed
quinnwai opened this issue Feb 23, 2024 · 2 comments
Closed

Create a batch get for the metakb API #290

quinnwai opened this issue Feb 23, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request priority:medium Medium priority

Comments

@quinnwai
Copy link

quinnwai commented Feb 23, 2024

Hi there! Wanted to get a conversation started for implementing a batch getter for the metakb API.

In contexts like processing a large number of variant IDs from a VCF, it could be helpful to send multiple IDs at once. For reference, on my 2017 MacBook Pro (2.3 GHz Dual-Core Intel Core i5 cores, 8GB memory) with multiprocessing, I max out at ~25 calls per second. Using this, working with a 16MB VCF (one patient, one chromosome) with 330k variants would take ~3.5 hours. The compute doesn't seem to be a problem, as I'm far from maxing out my CPU or memory. Considering this is a relatively small VCF, scaling this to the multi-patient, larger VCFs, and all chromosomes could end up being lengthy regardless of the machine.

Just wanted to provide some info for one use case, but happy to provide more info or discuss this more in detail.

@korikuzma korikuzma added enhancement New feature or request priority:low Low priority labels Feb 25, 2024
@korikuzma
Copy link
Member

@quinnwai Thanks for creating an issue for this. MetaKB V2 is still in early stages of development. This is a reasonable ask, I think the question is more on where it lives on the roadmap and which team would implement this. We can discuss this more at the MetaKB meeting on Tuesday and report back here afterwards.

@jsstevenson jsstevenson added priority:medium Medium priority and removed priority:low Low priority labels May 10, 2024
@jsstevenson jsstevenson self-assigned this May 10, 2024
Copy link

Closed by #361.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:medium Medium priority
Projects
None yet
Development

No branches or pull requests

3 participants