Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix your regex #33

Open
applibs opened this issue Jun 5, 2019 · 0 comments
Open

Please fix your regex #33

applibs opened this issue Jun 5, 2019 · 0 comments

Comments

@applibs
Copy link

applibs commented Jun 5, 2019

I have tested some formated sql scripts and after formated your regex not recognize some columns:
for example this is not recognized:
``quantity decimal(11, 2) unsigned NOT NULL DEFAULT '0.00',
because there is formated (11, 2) with space between number 2.
Your regex:
`decimal((?\d+),(?\d+))(?:\s+unsigned)?`
do nothing.
I temporary fixed by this line:
`decimal((?\d+),(?\s*\d+))(?:\s+unsigned)?`
Can you fix it in your code please to other columns type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant