Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard coded notification URL needs to become configurable #47

Open
rsdoiel opened this issue Nov 4, 2024 · 1 comment
Open

Hard coded notification URL needs to become configurable #47

rsdoiel opened this issue Nov 4, 2024 · 1 comment
Assignees
Milestone

Comments

@rsdoiel
Copy link
Member

rsdoiel commented Nov 4, 2024

Hard coded notification URL needs to become configurable as a top level item in cold_reports.yaml. There are a few related values hard coded and likewise they should be made configurable for the reports runner and UI.

@rsdoiel rsdoiel added this to the 0.1.0 milestone Nov 4, 2024
@rsdoiel rsdoiel self-assigned this Nov 4, 2024
@rsdoiel
Copy link
Member Author

rsdoiel commented Nov 21, 2024

I've added a baseUrl value to the config.ts interfaces. These need to propagate through. It'd be helpful to have this configurable via YAML or the environment.

When I get closer to a 0.1.0 release a code review needs to happen where we collect these types of hard coded values and make them configurable but also have sensible defaults.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant