Skip to content
This repository has been archived by the owner on Sep 25, 2024. It is now read-only.

.desktop File Creation Instructions Violate the Desktop Menu Specification. #102

Open
Gambloide opened this issue Aug 30, 2020 · 1 comment
Labels
compatibility Compatibility accross various DE

Comments

@Gambloide
Copy link

Description
The Create .desktop file section of the README.md does not adhere to the Desktop Menu Specification and fails validation:

$ desktop-file-validate protonvpn-gui.desktop
protonvpn-gui.desktop: error: value "False" for boolean key "Terminal" in group "Desktop Entry" contains invalid characters, boolean values must be "false" or "true"
protonvpn-gui.desktop: error: value "Utility;GUI;Network;VPN" for key "Categories" in group "Desktop Entry" contains an unregistered value "GUI"; values extending the format should start with "X-"
protonvpn-gui.desktop: hint: value "Utility;GUI;Network;VPN" for key "Categories" in group "Desktop Entry" contains more than one main category; application might appear more than once in the application menu
protonvpn-gui.desktop: error: value "Utility;GUI;Network;VPN" for key "Categories" in group "Desktop Entry" contains an unregistered value "VPN"; values extending the format should start with "X-"
  1. False should be false
  2. invalid categories should either be
    1. replaced with valid replacements
    2. removed
    3. indicated as extensions by prefixing them with "X-"

Working Example Passing Validation:

Terminal=false
Categories=Utility;X-GUI;Network;X-VPN

To Reproduce
Follow the installation instructions for Fedora from https://github.com/ProtonVPN/linux-gui/blob/master/README.md

Desktop:

  • OS: Fedora 32
  • Shell: Gnome 3.36
@calexandru2018
Copy link
Owner

calexandru2018 commented Aug 30, 2020

Hi @Gambloide 😊

Thanks for bringing this up. This is something that is very helpful. This should be fixed in the near future.

@calexandru2018 calexandru2018 added the compatibility Compatibility accross various DE label Aug 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
compatibility Compatibility accross various DE
Projects
None yet
Development

No branches or pull requests

2 participants