Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #3

Open
caitp opened this issue Aug 25, 2016 · 0 comments
Open

Code cleanup #3

caitp opened this issue Aug 25, 2016 · 0 comments

Comments

@caitp
Copy link
Owner

caitp commented Aug 25, 2016

This stuff is a mess.

Conventions should be established. I like the "TSW_" prefix for macros, and TSW might not be a bad prefix for many internal class names, either.

The "Impl" suffix may be a bit misleading, and should probably be replaced with something.

Includes should be sorted alphabetically, in sections: 1) libc++ headers, 2) libobs/library headers, 3) local includes.

No need for a column limit, but methods should probably not begin with the verb "get". They should, however, always begin with a verb, to clarify intent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant