Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should explore removal of conformal lock #472

Open
KeenanRileyFaulkner opened this issue Apr 13, 2024 · 1 comment
Open

Should explore removal of conformal lock #472

KeenanRileyFaulkner opened this issue Apr 13, 2024 · 1 comment

Comments

@KeenanRileyFaulkner
Copy link
Contributor

The conformal lock found in bfasst/locks.py seems to only be locking the use of conformal on the client side. If this is an artifact from back when all outputs were being dumped in the same directory across multiple designs, then it should be removed.

@jgoeders
Copy link
Member

We don't want two conformal tasks to run in parallel during a ninja build, as the code currently copies things to the same temporary location in the CAEDM machine. How are we handling this right now?

A proper solution would be to remove the lock, but have temp directory locations on the remote machine so that nothing is ever clobbered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants