Refactor release builds, add aarch64-musl #9885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit refactors the way release builds are done in CI in terms of configuration and then additionally adds aarch64-musl release artifacts as requested in bytecodealliance#9875. The refactoring here is done to reduce the number of locations to understand release builds. Notably the `binary-compatible-builds` action was removed in favor of direct environment configuration in conjunction with docker images used to build. The `aarch64-musl` build itself happens in a container provided by the `cross` project to ensure that the right toolchain is configured. Closes bytecodealliance#9875 prtest:full
|
@whitequark from this CI page if you scroll to the bottom and find |
|
OK so here is what I get if I run wasmtime in alpine edge on aarch64: |
|
I think this might be Alpine-specific, for some reason libgcc isn't installed by default? Anyway, after I fixed that, it ran and executed a real Wasm application (nextpnr). |
|
Ok perfect, thanks! I still don't know how to best manage libgcc_s on musl but it's at least no worse-off than the x64 target which I believe has the same behavior. |
dicej
approved these changes
Dec 21, 2024
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jan 6, 2025
* Refactor release builds, add aarch64-musl This commit refactors the way release builds are done in CI in terms of configuration and then additionally adds aarch64-musl release artifacts as requested in bytecodealliance#9875. The refactoring here is done to reduce the number of locations to understand release builds. Notably the `binary-compatible-builds` action was removed in favor of direct environment configuration in conjunction with docker images used to build. The `aarch64-musl` build itself happens in a container provided by the `cross` project to ensure that the right toolchain is configured. Closes bytecodealliance#9875 prtest:full * Link musl dynamically
This was referenced Jan 6, 2025
alexcrichton
added a commit
that referenced
this pull request
Jan 6, 2025
* Refactor release builds, add aarch64-musl This commit refactors the way release builds are done in CI in terms of configuration and then additionally adds aarch64-musl release artifacts as requested in #9875. The refactoring here is done to reduce the number of locations to understand release builds. Notably the `binary-compatible-builds` action was removed in favor of direct environment configuration in conjunction with docker images used to build. The `aarch64-musl` build itself happens in a container provided by the `cross` project to ensure that the right toolchain is configured. Closes #9875 prtest:full * Link musl dynamically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit refactors the way release builds are done in CI in terms of configuration and then additionally adds aarch64-musl release artifacts as requested in #9875. The refactoring here is done to reduce the number of locations to understand release builds. Notably the
binary-compatible-buildsaction was removed in favor of direct environment configuration in conjunction with docker images used to build. Theaarch64-muslbuild itself happens in a container provided by thecrossproject to ensure that the right toolchain is configured.Closes #9875