Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check whether related table has funcref elem in opcode call_indirect #3999

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Check whether related table has funcref elem in opcode call_indirect #3999

wants to merge 4 commits into from

Conversation

TianlongLiang
Copy link
Collaborator

This PR will resolve #3993

lum1n0us
lum1n0us approved these changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@lum1n0us lum1n0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lum1n0us
Copy link
Collaborator

lum1n0us commented Jan 3, 2025

The community added a test case for this scenario three months ago. It seems we need to update to the latest.

@lum1n0us lum1n0us mentioned this pull request Jan 3, 2025
Open
@lum1n0us
Copy link
Collaborator

lum1n0us commented Jan 3, 2025

FYI:

spec:

https://webassembly.github.io/spec/core/valid/instructions.html#xref-syntax-instructions-syntax-instr-control-mathsf-call-indirect-x-y

must be funcref

GC spec:

https://webassembly.github.io/gc/core/valid/instructions.html#xref-syntax-instructions-syntax-instr-control-mathsf-call-indirect-x-y

must match type ref null func

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lum1n0us lum1n0us lum1n0us approved these changes

@loganek loganek Awaiting requested review from loganek loganek is a code owner

@no1wudi no1wudi Awaiting requested review from no1wudi no1wudi is a code owner

@wenyongh wenyongh Awaiting requested review from wenyongh wenyongh is a code owner

@xujuntwt95329 xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 is a code owner

@yamt yamt Awaiting requested review from yamt yamt is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Table Type Validation in call_indirect Instruction
2 participants
@TianlongLiang @lum1n0us