From 825b1e767889a7d774ddc834bae246acce204afb Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Wed, 12 Apr 2023 10:51:15 -0700 Subject: [PATCH] Fix some fixmes in comments. (#314) Replace some fixmes for comments with actual comments. --- cap-primitives/src/fs/open_options.rs | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/cap-primitives/src/fs/open_options.rs b/cap-primitives/src/fs/open_options.rs index ea86f86a..9d81965b 100644 --- a/cap-primitives/src/fs/open_options.rs +++ b/cap-primitives/src/fs/open_options.rs @@ -141,28 +141,35 @@ impl OpenOptions { self } - /// Sets the option to enable fixme + /// Requests write operations complete as defined by synchronized I/O file + /// integrity completion. #[inline] pub(crate) fn sync(&mut self, enable: bool) -> &mut Self { self.sync = enable; self } - /// Sets the option to enable fixme + /// Requests write operations complete as defined by synchronized I/O data + /// integrity completion. #[inline] pub(crate) fn dsync(&mut self, enable: bool) -> &mut Self { self.dsync = enable; self } - /// Sets the option to enable fixme + /// Requests read operations complete as defined by the level of integrity + /// specified by `sync` and `dsync`. #[inline] pub(crate) fn rsync(&mut self, enable: bool) -> &mut Self { self.rsync = enable; self } - /// Sets the option to enable fixme + /// Requests that I/O operations fail with `std::io::ErrorKind::WouldBlock` + /// if they would otherwise block. + /// + /// This option is commonly not implemented for regular files, so blocking + /// may still occur. #[inline] pub(crate) fn nonblock(&mut self, enable: bool) -> &mut Self { self.nonblock = enable;