Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Map terminals to folder or file #38

Open
the-j0k3r opened this issue Mar 29, 2020 · 6 comments
Open

[FR] Map terminals to folder or file #38

the-j0k3r opened this issue Mar 29, 2020 · 6 comments
Labels
feature request 😍 Some feature could be added good first issue 🐝 Good for newcomers

Comments

@the-j0k3r
Copy link
Member

Describe the feature you'd like

Ala terminus

map to file

t-map_terminals_to_file

map to folder

t-map_terminals_to_folder

Additional context

This is extremely helpful

@the-j0k3r the-j0k3r added the feature request 😍 Some feature could be added label Mar 29, 2020
@UziTech
Copy link
Member

UziTech commented Mar 29, 2020

How would this feature work with terminals open in multiple locations?

image

It only seems to work well in terminus if all terminals are open in the bottom pane.

@the-j0k3r
Copy link
Member Author

the-j0k3r commented Mar 29, 2020

Yea, terminus is probably not handling that properly and its likely a little buggy, ideally it shouldn't matter where terminals are dragged to or opened into diff locations, until you close the terminal associated with a specific file or folder,

Then if there's no mapping it would be last active.

Does it makes sense that the location within Atom Window where you opened the terminal to should bare influence on the feature? It doesn't to me. =)

Nite and take care, ttyl

@UziTech
Copy link
Member

UziTech commented Mar 30, 2020

I don't quite understand what this feature would do in the context of x-terminal.

  • Does a mapped terminal mean that terminal is always the active terminal for that file/folder? or just initially activated when the file/folder is focused?
  • If a mapped terminal is focused when the file that is mapped to isn't open, can it still be an active terminal?
  • What exactly is this feature trying to accomplish? What steps would this save that could be done manually without this feature?

@the-j0k3r
Copy link
Member Author

the-j0k3r commented Mar 31, 2020

* Does a mapped terminal mean that terminal is always the active terminal for that file/folder? or just initially activated when the file/folder is focused?

It means that when you open a terminal with an active file/folder that terminal belongs to that file folder, however terminus does it seems to work fine bugs not withstanding.

If a mapped terminal is focused when the file that is mapped to isn't open, can it still be an active terminal?

Good one, how well can this be implemented? the terminal should close optionally or just close or fallback to the project dir?

Depending on scenario terminus is a bit buggy in places.

  • What exactly is this feature trying to accomplish? What steps would this save that could be done manually without this feature?

Thats question sort of answers itself, but currently you cant at all either know which folder or file the terminal youre opening or using belongs to.

But this is bigger issue that x-terminal cant do because terminus has several features that work in conjunction with this one.

Like Working Directory can be Home, Project or active file.

In this way, I cant work with x-terminal like in terminus.

In terminus I open my GitHub folder with Atom, then select a project on sidebar, then I click on a file and focus it, open a terminal for that project/file and walla

Instantly the term prompt indicate that Im in the project I want to edit and that at least it belongs to that file.
Also this is a single instance of atom.

When I work with x-terminal I can only open one project per Atom instance else x-terminal always things im in github dir and not in the actual github/someproject.

Yea I could cd in/out but thats just not the way you expect to work with terminals, which usually is open a terminal in this dir and its automatically there.

@the-j0k3r
Copy link
Member Author

the-j0k3r commented Mar 31, 2020

something like this

generic

Which is pretty much equivalent to this (except its stremlined to not require the context menu open term here)

generic

And x-terminal cant do these basic things, unless you crete umpteen profiles one for each, and thats just not a viable way to work in this manner.

@UziTech
Copy link
Member

UziTech commented Mar 31, 2020

So let me see if I understand what this feature is supposed to do:

When terminal file mapping is on, this feature would open a new terminal for every file that is opened and make the mapped terminal active when the file is focused.

Same thing for folder mapping but for each folder instead of each file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 😍 Some feature could be added good first issue 🐝 Good for newcomers
Development

No branches or pull requests

2 participants