From cbb696a9d1dc88ed05c7788b0e4904989086c630 Mon Sep 17 00:00:00 2001
From: Adrianna Chang <adrianna.chang@shopify.com>
Date: Fri, 12 Mar 2021 15:01:58 -0500
Subject: [PATCH] Allow configuration of storage service to use for uploading
 csv_file blob (#372)

---
 README.md                           | 33 ++++++++++++++++++++++++++++-
 app/models/maintenance_tasks/run.rb |  2 +-
 lib/maintenance_tasks.rb            |  6 ++++++
 3 files changed, 39 insertions(+), 2 deletions(-)

diff --git a/README.md b/README.md
index f0f7ba5d..a84f7260 100644
--- a/README.md
+++ b/README.md
@@ -22,6 +22,7 @@ A Rails engine for queuing and managing maintenance tasks.
     * [Customizing the maintenance tasks module](#customizing-the-maintenance-tasks-module)
     * [Customizing the underlying job class](#customizing-the-underlying-job-class)
     * [Customizing the rate at which task progress gets updated](#customizing-the-rate-at-which-task-progress-gets-updated)
+    * [Customizing which Active Storage service to use](#customizing-which-active-storage-service-to-use)
 * [Upgrading](#upgrading)
 * [Contributing](#contributing)
 * [Releasing new versions](#releasing-new-versions)
@@ -400,6 +401,36 @@ MaintenanceTasks.ticker_delay = 2.seconds
 
 If no value is specified, it will default to 1 second.
 
+#### Customizing which Active Storage service to use
+
+The Active Storage framework in Rails 6.1 and up supports multiple storage
+services per environment. To specify which service to use,
+`MaintenanceTasks.active_storage_service` can be configured with the service's
+key, as specified in your application's `config/storage.yml`:
+
+```yaml
+# config/storage.yml
+user_data:
+  service: GCS
+  credentials: <%= Rails.root.join("path/to/user/data/keyfile.json") %>
+  project: "my-project"
+  bucket: "user-data-bucket"
+
+internal:
+  service: GCS
+  credentials: <%= Rails.root.join("path/to/internal/keyfile.json") %>
+  project: "my-project"
+  bucket: "internal-bucket"
+```
+
+```ruby
+# config/initializers/maintenance_tasks.rb
+MaintenanceTasks.active_storage_service = :internal
+```
+
+There is no need to configure this option if your application uses only one
+storage service per environment.
+
 ## Upgrading
 
 Use bundler to check for and upgrade to newer versions. After installing a new
@@ -432,7 +463,7 @@ Once a release is ready, follow these steps:
 * Deploy via [Shipit][shipit] and see the new version on
   <https://rubygems.org/gems/maintenance_tasks>.
 * Ensure the release has documented all changes and publish it.
-* Create a new [draft release on GitHub][release] with the title 
+* Create a new [draft release on GitHub][release] with the title
   'Upcoming Release'. The tag version can be left blank. This will be the
   starting point for documenting changes related to the next release.
 
diff --git a/app/models/maintenance_tasks/run.rb b/app/models/maintenance_tasks/run.rb
index 27ac3501..6d8af229 100644
--- a/app/models/maintenance_tasks/run.rb
+++ b/app/models/maintenance_tasks/run.rb
@@ -48,7 +48,7 @@ class Run < ApplicationRecord
 
     validates_with RunStatusValidator, on: :update
 
-    has_one_attached :csv_file
+    has_one_attached :csv_file, service: MaintenanceTasks.active_storage_service
 
     # Sets the run status to enqueued, making sure the transition is validated
     # in case it's already enqueued.
diff --git a/lib/maintenance_tasks.rb b/lib/maintenance_tasks.rb
index 0804aa3a..ce9ce301 100644
--- a/lib/maintenance_tasks.rb
+++ b/lib/maintenance_tasks.rb
@@ -36,6 +36,12 @@ module MaintenanceTasks
   #   the ticker during Task iterations.
   mattr_accessor :ticker_delay, default: 1.second
 
+  # Specifies which Active Storage service to use for uploading CSV file blobs.
+  #
+  # @param [Symbol] the key for the storage service, as specified in the app's
+  #   config/storage.yml.
+  mattr_accessor :active_storage_service
+
   # Retrieves the callback to be performed when an error occurs in the task.
   def self.error_handler
     return @error_handler if defined?(@error_handler)