-Wshadow warnings in nfd_gtk.cpp

[azonenberg]

The following warnings are seen when compiling with -Wshadow enabled (and break the build when -Werror is active).

/ceph/fast/home/azonenberg/code/scopehal-apps/src/nativefiledialog-extended/src/nfd_gtk.cpp: In constructor ?{anonymous}::NativeWindowParenter::NativeWindowParenter(GtkWidget*, const nfdwindowhandle_t&)?:
/ceph/fast/home/azonenberg/code/scopehal-apps/src/nativefiledialog-extended/src/nfd_gtk.cpp:450:37: error: declaration of ?widget? shadows a member of ?{anonymous}::NativeWindowParenter? [-Werror=shadow]
  450 |     NativeWindowParenter(GtkWidget* widget, const nfdwindowhandle_t& parentWindow) noexcept
      |                          ~~~~~~~~~~~^~~~~~
/ceph/fast/home/azonenberg/code/scopehal-apps/src/nativefiledialog-extended/src/nfd_gtk.cpp:472:22: note: shadowed declaration is here
  472 |     GtkWidget* const widget;
      |                      ^~~~~~
/ceph/fast/home/azonenberg/code/scopehal-apps/src/nativefiledialog-extended/src/nfd_gtk.cpp: In constructor ?{anonymous}::NativeWindowParenter::NativeWindowParenter(GtkWidget*, const nfdwindowhandle_t&)?:
/ceph/fast/home/azonenberg/code/scopehal-apps/src/nativefiledialog-extended/src/nfd_gtk.cpp:450:37: error: declaration of ?widget? shadows a member of ?{anonymous}::NativeWindowParenter? [-Werror=shadow]
  450 |     NativeWindowParenter(GtkWidget* widget, const nfdwindowhandle_t& parentWindow) noexcept
      |                          ~~~~~~~~~~~^~~~~~
/ceph/fast/home/azonenberg/code/scopehal-apps/src/nativefiledialog-extended/src/nfd_gtk.cpp:472:22: note: shadowed declaration is here
  472 |     GtkWidget* const widget;
      |                      ^~~~~~
/ceph/fast/home/azonenberg/code/scopehal-apps/src/nativefiledialog-extended/src/nfd_gtk.cpp: In constructor ?{anonymous}::NativeWindowParenter::NativeWindowParenter(GtkWidget*, const nfdwindowhandle_t&)?:
/ceph/fast/home/azonenberg/code/scopehal-apps/src/nativefiledialog-extended/src/nfd_gtk.cpp:450:37: error: declaration of ?widget? shadows a member of ?{anonymous}::NativeWindowParenter? [-Werror=shadow]
  450 |     NativeWindowParenter(GtkWidget* widget, const nfdwindowhandle_t& parentWindow) noexcept
      |                          ~~~~~~~~~~~^~~~~~
/ceph/fast/home/azonenberg/code/scopehal-apps/src/nativefiledialog-extended/src/nfd_gtk.cpp:472:22: note: shadowed declaration is here
  472 |     GtkWidget* const widget;

[btzy]

Thanks for the bug report. Yes, this seems to be a problem.