Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nametag Issues #117

Open
bribes opened this issue Aug 22, 2022 · 5 comments
Open

Nametag Issues #117

bribes opened this issue Aug 22, 2022 · 5 comments

Comments

@bribes
Copy link

bribes commented Aug 22, 2022

When wearing a ear the name tag position doesn't move up this can be done manually but yeah. Also animations don't move the name tag. Ex. Flying Animation

While doing testing turns out you have to rotate the material itself to rotate the sprite.

@Hacksore Hacksore added the bug label Sep 8, 2022
@Hacksore
Copy link
Collaborator

Hacksore commented Sep 8, 2022

Picture for reference of the issue.
image

@zardoy
Copy link

zardoy commented May 23, 2024

@Hacksore I believe it is easy to fix just by adding the renderOrder.
However I doubt if canvas rendering should be used there: you load a new texture to GPU (which you should avoid), instead the native font rendering should be used instead which has almost zero overhead (since you load the font once and use glyphs to do 2d text rendering)

@Hacksore
Copy link
Collaborator

@zardoy Would you be willing to send a PR for this?

@Phoenix616
Copy link

Phoenix616 commented Dec 5, 2024

The name tag should be rendered "ten pixels higher to be above the ears" according to the wiki (not sure what measurement that is in-engine though), not just rendered visibly in front of the ears so changing render order wouldn't make it work properly.

@zardoy
Copy link

zardoy commented Dec 5, 2024

not sure what measurement that is in-engine though

that's why I think it's just easier to refer to the decompiled code instead

not just rendered visibly in front of the ears so changing render order wouldn't make it work properly.

I suppose it should be easy to fix, yes it was very annoying issues to skins that have ears

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants