Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling increment/decrement with tags, callback and no value #139

Open
aheuermann opened this issue Dec 6, 2019 · 1 comment
Open

Calling increment/decrement with tags, callback and no value #139

aheuermann opened this issue Dec 6, 2019 · 1 comment

Comments

@aheuermann
Copy link

I noticed that the following call results in an invalid metric format.

hotShots.increment('some.metric', { tagName: 'tags' }, callback);

I think the issue is due to the arguments length check here.

@bdeitte
Copy link
Collaborator

bdeitte commented Dec 8, 2019

Yep the way that increment and other functions deal with missing args is... unusual. But it's been this way for a long time and is a bit tough to consider changing for legacy reasons. If someone sees ways we can make this better that looks safe, and tests cover it, I'm good with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants