Certain tag values break telegraf

[lbeschastny]

I've found several cases when hot-shots sends malformed packets to telegraf.

tags ending with '\\' break telegraf for an unknown reason

Reproduction example:

const {StatsD} = require('hot-shots');
const client = new StatsD({telegraf: true});

client.increment('test', 1, {foo: 'bar\\'});

Telegraf output:

2019-09-19T11:34:50Z E! [outputs.influxdb]: when writing to [http://influxdb:8086]: received error unable to parse 'test,env=dev,env_type=staging,foo=bar\,host=bafcd9da9c22,metric_type=counter value=1i 1568892885000000000': invalid tag format; discarding points

Though it may be a telegraf issue, I think it still worth mentioning.

, in tag value is handled incorrectly

const {StatsD} = require('hot-shots');
const client = new StatsD({telegraf: true});

client.increment('test', 1, {foo: 'bar,baz'});

Resulting InfluxDB data:

> select * from test
name: test
time                env env_type foo host         metric_type value
----                --- -------- --- ----         ----------- -----
1568893035000000000 dev staging  bar bafcd9da9c22 counter     1

Instead of bar,baz only bar is saved.

This looks like a hot-shots issue which should be addressed in sanitizeTags helper.

[bdeitte]

Thanks for the heads up! We accept PRs for any issues, so if you or someone working with you would like to fix the ",", certainly would pull that in if it was made telegraf specific.

[lbeschastny]

Just opened #165 PR to fix , issue.

I'm not sure what we should do with trailing \ issue. Replacing it with _ doesn't look like a good idea since it works fine in any other place.

[bdeitte]

You could still update sanitizeTags to explicitly look for '_' right at the end the line in sanitizeTags, that would work. But fixing the comma issue, bringing that one in now, thanks.