Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefix and suffix don't work for events #119

Open
gdoron opened this issue Sep 19, 2019 · 4 comments
Open

prefix and suffix don't work for events #119

gdoron opened this issue Sep 19, 2019 · 4 comments

Comments

@gdoron
Copy link

gdoron commented Sep 19, 2019

Hi,

Consider this snippet:

const client = new StatsD({
    host: dogstatsdHost,
    port: dogstatsdPort,
    prefix: 'df.',
    globalTags: {
        environment: config.Configuration.Environment,
        application: config.Configuration.Application
    }
});

client.event('application_started');

Expected:

event of df.application_started is sent to datadog.

Actual

event of application_started is sent to datadog.

Is it a bug or by design?
If it's by design, this is very confusing...

Thanks!
Doron

@bdeitte
Copy link
Collaborator

bdeitte commented Sep 22, 2019

It feels like a bug to me too. I would do a minor or major release if changing it, would need to think more about which, just in case it causes unexpected issues, but does feel like an oversight.

@gdoron gdoron changed the title prefix and suffix don't don't work for events prefix and suffix don't work for events Sep 22, 2019
@gdoron
Copy link
Author

gdoron commented Sep 22, 2019

I think it's an important fix, but it's a major, stuff can break because of the fix.

@gdoron
Copy link
Author

gdoron commented Nov 27, 2019

@bdeitte Hi Brian.
Is there any update on this?
Would you accept a pull request if I'll fix it?

@bdeitte
Copy link
Collaborator

bdeitte commented Nov 30, 2019

@gdoron No update here on it. I would accept a pull request to fix it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants