Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It breaks some html tags #4

Open
u07 opened this issue Jan 9, 2023 · 4 comments
Open

It breaks some html tags #4

u07 opened this issue Jan 9, 2023 · 4 comments

Comments

@u07
Copy link

u07 commented Jan 9, 2023

Hi! I noticed, that my scripts stopped working. Cause this:

# This is markdown with html

<script type="text/javascript">
    function(w,d,c){var s=d.createElement('script')}
</script>

becomes:

<h1>This is markdown with html</h1>

  <script type="text/javascript">
  function(w,d,c){var s=d.createElement(”script”)}
  </script>

With fancy quotes inside script tag: ”script”

@u07
Copy link
Author

u07 commented Jan 9, 2023

And it took time to understand, why this got broken:

<style> #search-desktop { display: none; } </style>

image

@u07
Copy link
Author

u07 commented Jan 9, 2023

Okay, I see. You don't call $PHPTypoSettings->set_defaults(); so php-typography stays out of fine-tune.

I would recommend adding this to better-typography.php, line 131:

		$PHPTypoSettings->set_tags_to_ignore();
		$PHPTypoSettings->set_classes_to_ignore();
		$PHPTypoSettings->set_ids_to_ignore();

image

@bricebou
Copy link
Owner

Hi,
Thanks for reporting this issue !

I'm currently following a dev course and I'm planning on reviewing this plugin soon ! I'll see if I can do a better work :-)

@u07
Copy link
Author

u07 commented Jan 13, 2023

It is already a very helping thing) Thanks for your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants