New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when config is set to watch branch that's not master, wrong sha given #34

Open

jennschiffer opened this issue Feb 4, 2016 · 1 comment

jennschiffer commented Feb 4, 2016

i tried testing hookshot in a branch where i set it up (see https://github.com/bocoup/service-catalog/blob/master/.hookshot.conf#L8) but it wasn't work. had to land it in master to get it going. @tkellen can speak more to this!

Collaborator

tkellen commented Feb 5, 2016

I don't have an isolated repro for this, but I'll try to describe really clearly how to reproduce this:

create a repo with no .hookshot.confin master.
set up hookshot webhook
create a branch, in that branch, add a .hookshot.conf that references the new branch
push commits to the branch
hookshot uses the wrong sha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment