Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode the full opening fee params object in the promise itself #197

Open
JssDWt opened this issue Feb 29, 2024 · 1 comment
Open

Encode the full opening fee params object in the promise itself #197

JssDWt opened this issue Feb 29, 2024 · 1 comment

Comments

@JssDWt
Copy link
Collaborator

JssDWt commented Feb 29, 2024

All values in the opening fee params object are encoded (encrypted) into the promise itself. Sometimes new fields are added, and they are not returned by the client, because the client doesn't know about these fields yet. If the values are encoded inside the promise itself, the LSP only has to look at this field in order to extract the proper values. Even the ones that were not included by the client itself.

@JssDWt
Copy link
Collaborator Author

JssDWt commented Feb 29, 2024

Related: BitcoinAndLightningLayerSpecs/lsp#94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant