Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate derive_bip32_key to upstream LWK #317

Closed
ok300 opened this issue Jun 19, 2024 · 4 comments
Closed

Delegate derive_bip32_key to upstream LWK #317

ok300 opened this issue Jun 19, 2024 · 4 comments

Comments

@ok300
Copy link
Contributor

ok300 commented Jun 19, 2024

Create a LWK PR to encapsulate and expose derive_bip32_key.

Once implemented, this should replace our OnchainWallet::derive_bip32_key.

This will allow us to not work with the seed directly when during LNURL-auth.

@ok300 ok300 self-assigned this Jun 19, 2024
@ok300 ok300 mentioned this issue Jun 19, 2024
8 tasks
@LeoComandini
Copy link

Blockstream/lwk@f6c24d6

will be available in next release

@ok300
Copy link
Contributor Author

ok300 commented Jun 25, 2024

Nice! Thanks @LeoComandini

@ok300
Copy link
Contributor Author

ok300 commented Jul 15, 2024

We updated to the latest LWK, but the new LWK derive_xprv uses structs in bitcoin crate v0.31.2.

sdk-common uses structs from bitcoin crate v0.29.2 for compatibility with GL / VLS.

Unfortunately they're not compatible, so we'll have to wait until GL / VLS update to at least v0.31.2. Another option is to manually convert between the structs, but that's a lot of boilerplate and it touches many inner structs.

@ok300 ok300 removed their assignment Jan 10, 2025
@dangeross
Copy link
Collaborator

Signer trait makes this redundant

@dangeross dangeross closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants