Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outline mode is not working properly #5

Closed
jaydson opened this issue Oct 3, 2018 · 2 comments
Closed

Outline mode is not working properly #5

jaydson opened this issue Oct 3, 2018 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@jaydson
Copy link
Member

jaydson commented Oct 3, 2018

For some items it shows only :.
@jaydson jaydson added bug Something isn't working help wanted Extra attention is needed labels Oct 3, 2018
jaydson pushed a commit that referenced this issue Oct 3, 2018
@felipenmoura
Fixed problem of extra elements being copyed alongside the correct te…
af59465 
…xt and markup.

This fixes issue #5
@RenatoSiqueira
Copy link
Contributor

RenatoSiqueira commented Oct 4, 2018 •
edited
Loading

Eu fiz o rastreamento e isso acontece quando as pessoas abrem as issues fora do padrão markdown. Neste caso, duas sugestões que estão fora da minha alçada:

  1. Trocar o 'Template para uma boa dica:' para 'Obrigatório usar este Template:' (realçando que o markdown é extremamente necessário.
  2. Criar alguma função extra para tratar isso nesses casos.

É o que pude fazer até o momento.
Talvez eu esboce essa função extra, mas devo demorar um pouco mais.

Se alguém se interessar, o processo é verificar se a Linha 8 ( this.mdBody = data.body ) do classes/comment.js está vindo como markdown e tratar.

Abraços!

Edit¹: i will try!

@RenatoSiqueira
Copy link
Contributor

RenatoSiqueira commented Oct 8, 2018 •
edited
Loading

Finally!
Done in PR #27

RenatoSiqueira added a commit to RenatoSiqueira/newslleter-tool that referenced this issue Oct 8, 2018
@RenatoSiqueira
Issue braziljs#5 - Outline
d662b15
RenatoSiqueira added a commit to RenatoSiqueira/newslleter-tool that referenced this issue Oct 8, 2018
@RenatoSiqueira
Issue braziljs#5/ braziljs#1
487ef99
This was referenced Oct 8, 2018
Merged
Closed
@jaydson jaydson closed this as completed Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaydson @RenatoSiqueira