From c7a040f13916cec0dbd22ca26218e5de10833992 Mon Sep 17 00:00:00 2001 From: brave-builds Date: Tue, 14 Jan 2025 17:03:28 +0000 Subject: [PATCH] Uplift of #27202 (squashed) to beta --- .../components/home/ads_settings_modal.tsx | 39 +++++---- .../components/home/earning_card.style.ts | 6 ++ .../components/home/earning_card.tsx | 79 +++++++++++-------- .../rewards_page/components/modal.style.ts | 8 +- 4 files changed, 79 insertions(+), 53 deletions(-) diff --git a/components/brave_rewards/resources/rewards_page/components/home/ads_settings_modal.tsx b/components/brave_rewards/resources/rewards_page/components/home/ads_settings_modal.tsx index 5c53f777ac65..0c27ae2faf9e 100644 --- a/components/brave_rewards/resources/rewards_page/components/home/ads_settings_modal.tsx +++ b/components/brave_rewards/resources/rewards_page/components/home/ads_settings_modal.tsx @@ -121,22 +121,31 @@ export function AdsSettingsModal(props: Props) { onClose={props.onClose} />
-

- {getString('adsSettingsText')} - {' '} - - {getString('learnMoreLink')} - -

+ { + externalWallet && +

+ {getString('adsSettingsText')} + {' '} + + {getString('learnMoreLink')} + +

+ }
-
- - {getString('adsSettingsPayoutDateLabel')} - - - {payoutDateFormatter.format(new Date(adsInfo.nextPaymentDate))} - -
+ { + externalWallet && +
+ + {getString('adsSettingsPayoutDateLabel')} + + + { + payoutDateFormatter.format( + new Date(adsInfo.nextPaymentDate)) + } + +
+ }
{getString('adsSettingsTotalAdsLabel')} diff --git a/components/brave_rewards/resources/rewards_page/components/home/earning_card.style.ts b/components/brave_rewards/resources/rewards_page/components/home/earning_card.style.ts index aad576f64eb6..547d9a39147a 100644 --- a/components/brave_rewards/resources/rewards_page/components/home/earning_card.style.ts +++ b/components/brave_rewards/resources/rewards_page/components/home/earning_card.style.ts @@ -101,6 +101,12 @@ export const style = scoped.css` gap: 8px; padding: 4px 0; } + + .unconnected & { + margin-top: 12px; + padding-top: 8px; + border-top: solid 1px ${color.divider.subtle}; + } } .warning-box { diff --git a/components/brave_rewards/resources/rewards_page/components/home/earning_card.tsx b/components/brave_rewards/resources/rewards_page/components/home/earning_card.tsx index c657176fb00e..5725c1833d9e 100644 --- a/components/brave_rewards/resources/rewards_page/components/home/earning_card.tsx +++ b/components/brave_rewards/resources/rewards_page/components/home/earning_card.tsx @@ -55,6 +55,19 @@ export function EarningCard() { setShowAdsHistoryModal(!showAdsHistoryModal) } + function renderAdsNav() { + return ( +
+ + +
+ ) + } + function renderLimited() { return (
@@ -74,22 +87,25 @@ export function EarningCard() { }
-
-
-
- {getString('connectAccountText')} -
-
- {getString('connectAccountSubtext')} +
+
+
+
+ {getString('connectAccountText')} +
+
+ {getString('connectAccountSubtext')} +
+
- + {renderAdsNav()}
) @@ -150,35 +166,30 @@ export function EarningCard() { { showAdDetails && <> -
- - -
+ {renderAdsNav()} }
) } - if (!externalWallet) { - return renderLimited() + function renderConnected() { + return ( +
+ +
+ BAT +
+ {renderEarningsCounter()} +
+
+ {renderAdsSummary()} +
+ ) } return <> -
- -
- BAT -
- {renderEarningsCounter()} -
-
- {renderAdsSummary()} -
+ {externalWallet ? renderConnected() : renderLimited()} { showAdsHistoryModal ? : diff --git a/components/brave_rewards/resources/rewards_page/components/modal.style.ts b/components/brave_rewards/resources/rewards_page/components/modal.style.ts index c1a4b0f06911..634c7b889c62 100644 --- a/components/brave_rewards/resources/rewards_page/components/modal.style.ts +++ b/components/brave_rewards/resources/rewards_page/components/modal.style.ts @@ -39,6 +39,10 @@ export const modalStyle = scoped.css` border-radius: 16px 16px 0 0; margin: auto 0 0 0; } + + .modal-skip-animations & { + --self-animation-duration: 0ms; + } } @keyframes modal-content-fade-in { @@ -61,10 +65,6 @@ export const modalStyle = scoped.css` animation-fill-mode: both; } - .modal-skip-animations &::backdrop { - animation-duration: 0ms; - } - @keyframes modal-backdrop-fade { from { background: rgba(0, 0, 0, 0);