From fa6cf2138657b0ef2a808e4bb766c6d2b4e3dc00 Mon Sep 17 00:00:00 2001 From: Simon Hong Date: Wed, 15 Jan 2025 13:58:02 +0900 Subject: [PATCH] Fixed tab layout is not updated after swap in vertical tab https://github.com/brave/brave-browser/issues/43276 We need to update split tab's border insets in vertical tab as top & bottom tab in tile use different insets. --- browser/ui/views/tabs/brave_tab_container.cc | 4 ++++ browser/ui/views/tabs/brave_tab_container.h | 1 + 2 files changed, 5 insertions(+) diff --git a/browser/ui/views/tabs/brave_tab_container.cc b/browser/ui/views/tabs/brave_tab_container.cc index 2d8364661407..23fde5ec9a4e 100644 --- a/browser/ui/views/tabs/brave_tab_container.cc +++ b/browser/ui/views/tabs/brave_tab_container.cc @@ -614,6 +614,10 @@ void BraveTabContainer::OnDidBreakTile(const TabTile& tile) { SchedulePaint(); } +void BraveTabContainer::OnSwapTabsInTile(const TabTile& tile) { + UpdateTabsBorderInTile(tile); +} + gfx::Rect BraveTabContainer::GetDropBounds(int drop_index, bool drop_before, bool drop_in_group, diff --git a/browser/ui/views/tabs/brave_tab_container.h b/browser/ui/views/tabs/brave_tab_container.h index 099083ad2743..476eda70b93f 100644 --- a/browser/ui/views/tabs/brave_tab_container.h +++ b/browser/ui/views/tabs/brave_tab_container.h @@ -61,6 +61,7 @@ class BraveTabContainer : public TabContainerImpl, // SplitViewBrowserDataObserver: void OnTileTabs(const TabTile& tile) override; void OnDidBreakTile(const TabTile& tile) override; + void OnSwapTabsInTile(const TabTile& tile) override; private: class DropArrow : public views::WidgetObserver {