From d7a7704afd547eb507b861f854821b9bda69192a Mon Sep 17 00:00:00 2001 From: Simon Hong Date: Tue, 14 Jan 2025 16:33:56 +0900 Subject: [PATCH 1/2] Fixed split view menu bubble is not hidden after command runs fix https://github.com/brave/brave-browser/issues/43253 --- browser/ui/views/split_view/split_view_menu_bubble.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/browser/ui/views/split_view/split_view_menu_bubble.cc b/browser/ui/views/split_view/split_view_menu_bubble.cc index 294d7d825e9f..cca1a17b3f2b 100644 --- a/browser/ui/views/split_view/split_view_menu_bubble.cc +++ b/browser/ui/views/split_view/split_view_menu_bubble.cc @@ -82,6 +82,11 @@ SplitViewMenuBubble::SplitViewMenuBubble(Browser* browser, views::View* anchor) return base::BindRepeating( [](Browser* browser, int command_id, const ui::Event& event) { chrome::ExecuteCommand(browser, command_id); + // Some platform steals this bubble's focus and make it closed + // implicitely. But some doesn't. So, do close explicitely. + if (g_bubble) { + g_bubble->GetWidget()->Close(); + } }, browser, command_id); }; From 0874be00d755670af027c27626173b4cd41b43f6 Mon Sep 17 00:00:00 2001 From: Simon Hong Date: Wed, 15 Jan 2025 09:50:59 +0900 Subject: [PATCH 2/2] Update browser/ui/views/split_view/split_view_menu_bubble.cc Updated comments. Co-authored-by: Jay Harris --- browser/ui/views/split_view/split_view_menu_bubble.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/browser/ui/views/split_view/split_view_menu_bubble.cc b/browser/ui/views/split_view/split_view_menu_bubble.cc index cca1a17b3f2b..66356cae7e8b 100644 --- a/browser/ui/views/split_view/split_view_menu_bubble.cc +++ b/browser/ui/views/split_view/split_view_menu_bubble.cc @@ -82,8 +82,8 @@ SplitViewMenuBubble::SplitViewMenuBubble(Browser* browser, views::View* anchor) return base::BindRepeating( [](Browser* browser, int command_id, const ui::Event& event) { chrome::ExecuteCommand(browser, command_id); - // Some platform steals this bubble's focus and make it closed - // implicitely. But some doesn't. So, do close explicitely. + // Some platforms steal this bubble's focus closing + // implicitly but some don't, so we need to close it explicitly. if (g_bubble) { g_bubble->GetWidget()->Close(); }