From 632e42be4900c07d441bf6a1cf685a0ec5acaed6 Mon Sep 17 00:00:00 2001 From: oisupov Date: Thu, 23 Jan 2025 00:41:55 +0400 Subject: [PATCH] Review fix --- .../browser/zcash/zcash_wallet_service.cc | 25 ++++++++----------- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/components/brave_wallet/browser/zcash/zcash_wallet_service.cc b/components/brave_wallet/browser/zcash/zcash_wallet_service.cc index b6bf1775287e..26c4df1f55fb 100644 --- a/components/brave_wallet/browser/zcash/zcash_wallet_service.cc +++ b/components/brave_wallet/browser/zcash/zcash_wallet_service.cc @@ -660,16 +660,14 @@ void ZCashWalletService::CreateTransparentToOrchardTransaction( void ZCashWalletService::CreateTransactionTaskDone( ZCashCreateTransparentToOrchardTransactionTask* task) { - bool removed = create_shield_transaction_tasks_.remove_if( - [task](auto& item) { return item.get() == task; }); - DCHECK(removed); + CHECK(create_shield_transaction_tasks_.remove_if( + [task](auto& item) { return item.get() == task; })); } void ZCashWalletService::CreateTransactionTaskDone( ZCashCreateOrchardToOrchardTransactionTask* task) { - bool removed = create_shielded_transaction_tasks_.remove_if( - [task](auto& item) { return item.get() == task; }); - DCHECK(removed); + CHECK(create_shielded_transaction_tasks_.remove_if( + [task](auto& item) { return item.get() == task; })); } void ZCashWalletService::CreateShieldAllTransactionTaskDone( @@ -863,22 +861,19 @@ void ZCashWalletService::OnTransactionResolvedForStatus( void ZCashWalletService::CompleteTransactionTaskDone( ZCashCompleteTransactionTask* task) { - bool removed = complete_transaction_tasks_.remove_if( - [task](auto& item) { return item.get() == task; }); - DCHECK(removed); + CHECK(complete_transaction_tasks_.remove_if( + [task](auto& item) { return item.get() == task; })); } void ZCashWalletService::CreateTransactionTaskDone( ZCashCreateTransparentTransactionTask* task) { - bool removed = create_transaction_tasks_.remove_if( - [task](auto& item) { return item.get() == task; }); - DCHECK(removed); + CHECK(create_transaction_tasks_.remove_if( + [task](auto& item) { return item.get() == task; })); } void ZCashWalletService::ResolveBalanceTaskDone(ZCashResolveBalanceTask* task) { - bool removed = resolve_balance_tasks_.remove_if( - [task](auto& item) { return item.get() == task; }); - DCHECK(removed); + CHECK(resolve_balance_tasks_.remove_if( + [task](auto& item) { return item.get() == task; })); } ZCashRpc& ZCashWalletService::zcash_rpc() {