Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transport.ForceAttemptHTTP2 = false only in cert-cases? #314

Open
ibihim opened this issue Nov 12, 2024 · 0 comments
Open

transport.ForceAttemptHTTP2 = false only in cert-cases? #314

ibihim opened this issue Nov 12, 2024 · 0 comments
Assignees
@stlaz
Labels
sig-auth-acceptance issues created during review for sig-auth-acceptance

Comments

@ibihim
Copy link
Collaborator

ibihim commented Nov 12, 2024

Question

Is it intended that transport.ForceAttemptHTTP2 is set to false only if if len(upstreamCAPath) > 0 or if len(upstreamClientCertPath) > 0 are true?

[link](https://github.com/brancz/kube-rbac-proxy/pull/229/files#diff-d84eac55294d8f540a660bfcb4043f7c4e1f76c8bccbb91c129e8e4992dbafe7R95
@ibihim ibihim added the sig-auth-acceptance issues created during review for sig-auth-acceptance label Nov 12, 2024
@stlaz stlaz mentioned this issue Dec 2, 2024
Merged
@stlaz stlaz self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stlaz stlaz

Labels
sig-auth-acceptance issues created during review for sig-auth-acceptance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stlaz @ibihim