Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use namespaced keywords for all re-frame event names in braid #378

Open
rafd opened this issue May 30, 2017 · 0 comments
Open

use namespaced keywords for all re-frame event names in braid #378

rafd opened this issue May 30, 2017 · 0 comments
Labels

Comments

@rafd
Copy link
Member

rafd commented May 30, 2017

Currently, we are using a mix of non-namespaced keywords (ie. :some-event) or custom-namespaced keywords (ie. `:foo/some-event).

Suggestion:

  • when defining events, just use the local namespace (ie. ::some-event)

Pro:

  • clarifies exactly where each event is defined

Con:

  • verbosity when dispatching (ex. (dispatch [:braid.client.core.events/initialize]) vs. (dispatch [:core/initialize]))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants