Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix frequent "disconnects" #152

Closed
braid-sync opened this issue Sep 4, 2018 · 3 comments
Closed

fix frequent "disconnects" #152

braid-sync opened this issue Sep 4, 2018 · 3 comments
Labels

Comments

@braid-sync
Copy link

No description provided.

@braid-sync
Copy link
Author

➤ Rafal Dittwald commented:

I suspect it has something to do with a long running transaction;
implementing add multiple states to messages (sending, waiting, error, sent, new, seen) would alleviate the issue

@braid-sync braid-sync added the bug label Sep 4, 2018
@jamesnvc
Copy link
Contributor

Seeing this still, in conjunction with extremely high CPU usage, right after a new user joined...there's also a group that seems to have some sort of corrupted state (see #194) which is maybe a causal factor.

@jamesnvc
Copy link
Contributor

Observation: CPU spikes on the server right after a message is sent but if the thread the message is in doesn't have any tags, only @-mentioned users, it seems okay. Issue calculating message visibility based on tags?

rafd added a commit that referenced this issue Jul 15, 2019
Related #152

braid.core.server.sync-helpers/notify-users was repeatedly looking up users-for-user and tags-for-user (via message-format/parse-tags-and-mentions), which was a holdover from back when threads could be in multiple groups. Also, it was blocking. Reduced the repeated looping and put it in a future..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants