Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table row text is not vertically centered #970

Closed
christian-konrad opened this issue Jan 6, 2024 · 3 comments
Closed

Table row text is not vertically centered #970

christian-konrad opened this issue Jan 6, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@christian-konrad
Copy link
Contributor

Describe the Bug

Table row text is not vertically centered
image

Steps to Reproduce

  1. Add a table to a form
  2. The default content is shown
  3. It is aligned to the top, not to the center

Expected Behavior

Environment

  • Host: Chrome, form-js 1.6.2
  • OS: MacOS
@christian-konrad christian-konrad added the bug Something isn't working label Jan 6, 2024
@Skaiir
Copy link
Contributor

Skaiir commented Jan 8, 2024

@christian-konrad Yeah I noticed this as well.
It's a web modeler only problem, carbon css files are causing some problems over there.

@christian-konrad
Copy link
Contributor Author

Sounds Web Modeler should have rules to cover it. It shouldn't be a problem of form-js. @Skaiir are you able to provide them a PR to add a rule to fix it?

@Skaiir
Copy link
Contributor

Skaiir commented Jan 8, 2024

@christian-konrad I could also enforce it here, to have a higher specificity rule that force centering, even if it causes no actual changes to how it would render within the library.

@Skaiir Skaiir self-assigned this Jan 9, 2024
@Skaiir Skaiir added the ready Ready to be worked on label Jan 9, 2024
Skaiir added a commit that referenced this issue Jan 11, 2024
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jan 11, 2024
Skaiir added a commit that referenced this issue Jan 11, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jan 11, 2024
Skaiir added a commit that referenced this issue Jan 12, 2024
@Skaiir Skaiir closed this as completed Jan 16, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants