Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add placeholder for the name field #879

Open
barmac opened this issue Jun 3, 2024 · 4 comments
Open

Add placeholder for the name field #879

barmac opened this issue Jun 3, 2024 · 4 comments
Labels

Comments

@barmac
Copy link
Member

barmac commented Jun 3, 2024

What should we do?

Add placeholder for the name field in boxed expression editor.

Why should we do it?

Guide users.

@barmac barmac added backlog Queued in backlog Boxed Expression labels Jun 3, 2024
@lmbateman
Copy link

How about this for the placeholder wording?

  • Name field: "Enter business knowledge model name" - placeholder text color (#A8A8A8)
  • Expression field: "Enter FEEL expression" (could change to Java or PMML as appropriate) - placeholder text color
  • Variable name: "Enter BKM name above" - helper text color (#6F6F6F) so it doesn't look like the clickable text

image

@barmac
Copy link
Member Author

barmac commented Jun 7, 2024

I'm not sure if this not too verbose. Perhaps simple "Name" could serve the purpose well enough. WDYT?
Thanks for the colors proposal.
Regarding the different kinds (FEEL, Java, PMML), there is no place for an expression if we follow the spec (#857). So in the end only a FEEL expression can be given.

@lmbateman
Copy link

I like to include a verb to prompt the user to do something. How about, "Enter name"?

For the expression box, I think it would be nice to keep "Enter FEEL expression" so the user knows what language to use. If you think that they'll already know to use FEEL from working with BPMN, then we could leave it out.

Also, what happens if the user enters an expression in a different language? Will they get an error? (And if so, does it direct them to use FEEL?)

@barmac
Copy link
Member Author

barmac commented Jun 7, 2024

We can't tell for sure whether they are trying to write in a different language or they just made a syntax error. They will see an error anyway if the expression is invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants