Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource options should support multi specification with better semantics #14

Open
ahakanbaba opened this issue Jun 9, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@ahakanbaba
Copy link
Contributor

The resource options https://github.com/box/wavectl/blob/master/doc/CommandReference.md#resource-options should have better semantics if they are specified multiple times.

Right now, the later specified one overwrites an earlier specified one.

I think append action here is more suitable for them.
Whatever is specified mutiple times, the implementation should AND the speficied options.

For example if the user has specified
wavectl show alert --name "Kubernetes" --name "Node[0-9]+1"
the command should only return alerts whose name match both "Kubernetes" AND "Node[0-9]+1" regular expressions

@ahakanbaba ahakanbaba added the enhancement New feature or request label Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant