You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here is a security issue I've already addressed to @mpociot but I can't start working on it yet, community awareness is needed.
As we all know by default Botman Studio set all bot webhooks to route: example.com/botman
The thing is Telegram by default doesn't send any auth details to your webhook, you can't check and be sure requests are coming from them.
All of Botman Studio apps with Telegram Driver affected, anyone who knows a server running with Botman Studio and Telegram driver could send a custom update request to example.com/botmanwithout authorization whatsoever.
This issue is not purely Telegram Driver's, here are suggested solutions:
Passing optional secret_token at the webhook setup console command (for example, the Bot token itself) with the setWebhook and making a middleware to check every update authenticity.
Webhook separation (from default /botman) and hardening example.com/botman/telegramBotToken12345
Checking request origin IP with Telegram servers list (which can change over time)
Hello.
Here is a security issue I've already addressed to @mpociot but I can't start working on it yet, community awareness is needed.
As we all know by default Botman Studio set all bot webhooks to route:
example.com/botman
The thing is Telegram by default doesn't send any auth details to your webhook, you can't check and be sure requests are coming from them.
All of Botman Studio apps with Telegram Driver affected, anyone who knows a server running with Botman Studio and Telegram driver could send a custom update request to
example.com/botman
without authorization whatsoever.This issue is not purely Telegram Driver's, here are suggested solutions:
secret_token
at the webhook setup console command (for example, the Bot token itself) with thesetWebhook
and making a middleware to check every update authenticity./botman
) and hardeningexample.com/botman/telegramBotToken12345
Read more: https://core.telegram.org/bots/api#setwebhook
PRs are welcome.
The text was updated successfully, but these errors were encountered: