Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIGTERM is not stopping program during node startup #3209

Closed
1 of 2 tasks
mkykadir opened this issue Mar 17, 2022 · 2 comments
Closed
1 of 2 tasks

SIGTERM is not stopping program during node startup #3209

mkykadir opened this issue Mar 17, 2022 · 2 comments
Milestone
6.1 TestNet Phase A

Comments

@mkykadir
Copy link
Contributor

mkykadir commented Mar 17, 2022 •
edited
Loading

During runNode if we have long running operation, such as replaying from storage, node cannot be stopped with SIGTERM.

When a node lost state.db, it starts replaying blocks from storage. During this, Ctrl + C is not handled properly and node cannot be stopped. Main cause is, replaying starts during ctor of the node, thus listeners.node cannot be assigned and is null. Following check fails to stop the node.

agora/source/agora/node/main.d

Line 245 in dd2491c

if (listeners.node !is null)

  • Extract task loops of nodes
  • Document exit race conditions within loops
@mkykadir mkykadir self-assigned this Mar 17, 2022
@mkykadir mkykadir changed the title SIGTERM is not stopping node while replaying block storage SIGTERM is not stopping program during node startup Mar 18, 2022
@mkykadir
Copy link
Contributor Author

Updated issue details, since its not just related with block replaying but during runNode in general.

@mkykadir
Copy link
Contributor Author

Related with #3158

@hewison-chris hewison-chris added this to the 6. TestNet Phase A milestone Apr 14, 2022
@mkykadir mkykadir removed their assignment Sep 13, 2022
@mkykadir mkykadir closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1 TestNet Phase A
Development

No branches or pull requests
4 participants
@mkykadir @hewison-chris and others