Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost_1_76_0 collection_size_type copy.hpp filename with additional space? #237

Open
zhmzhen opened this issue Jun 9, 2021 · 7 comments

Comments

@zhmzhen
Copy link

zhmzhen commented Jun 9, 2021

Hi Dear receiver,

I am new here, thanks for your time and input in advance.

As tittle, recently, I tried to use latest boost
https://boostorg.jfrog.io/artifactory/main/release/1.76.0/source/boost_1_76_0.tar.gz
to build on one linux machine, it report error when doing related making due to there is one strange space character in the filename "collection_size_type copy.hpp"
Is that expected or on purpose?
It seems not a friendly file name for linux related tool chain operation.
image

Thanks,
Charley

@zhmzhen
Copy link
Author

zhmzhen commented Jun 9, 2021

BTW, I have checked the source code of version boost_1_72_0, it is OK for the filename,
So is that something by mistake?

Thanks,
Charley

@mclow mclow transferred this issue from boostorg/boost Jun 9, 2021
@mclow
Copy link
Contributor

mclow commented Jun 9, 2021

I can see it in the 1.76.0 release.
I see it in the master branch.
I do not see it in the develop branch.

@robertramey
Copy link
Member

this is a mistake. I don't know how I did it, but it shouldn't appear in the master branch.

I think someone pointed it out to me and I removed from develop. I generally only update the master by doing a "squash merger" from develop and I generally only do that once soon before release. So it should disappear from the master at the next release.

If you need immediate relief, just remove it from your local copy.

Thanks for pointing this out.

@zhmzhen
Copy link
Author

zhmzhen commented Jun 10, 2021

Thanks for all your information, it is clear for me,

Besides, I checked this issue in package since version 1_74_0, it is ok in version 1_73_0.
I can upgrade our boost from 1_72_0 to 1_73_0 for now,
while just want to know when it will official remove related files later? eg: 1 month later or in version 1_77_0?
^_^

Would you please let me know the date if possible, so we can work with latest great boost smoothly.

Thanks,
Charley

@mzhan0170
Copy link

Will boost add this issue to release note for 1.76.0? how does boost publish such issues?
Thanks,
Mark

@emmataobao
Copy link

emmataobao commented Dec 14, 2021

Hi,

I see this issue still exist in the latest release 1.78.0? do you have plan to fix it?
Another question, if i want to build 1.78.0, do i remove this file directly?

@icanhasmath
Copy link

Hey,

This file is still in release 1.82.0. The space causes an issue when building a Tensorflow wheel against it:

cp: cannot stat './local_config_python/python_include/boost-1_80/boost/serialization/collection_size_type': No such file or directory

I'm removing the file locally, but simply replacing the space with an underscore would make this a non-issue.
Best,
Marc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants