Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UrlUtilities problems (and how to solve them) #723

Open
BPP4634 opened this issue Mar 10, 2024 · 0 comments
Open

UrlUtilities problems (and how to solve them) #723

BPP4634 opened this issue Mar 10, 2024 · 0 comments

Comments

@BPP4634
Copy link

BPP4634 commented Mar 10, 2024

Good afternoon. I've been looking up your code and I think you could make some minor improvements to the UrlUtilities class. First, there is a never-ending recursive method: the buildUrl with 4 parameters, and second, I think you should take into consider changing some hardcoded strings like "https" or "http" into constants, as they are used many times there. I have also attached a file of what the solution could be like.
I know this text doesn't match the issue template, but I don't think I should follow that template for this particular one.

ISSUE FLICKR4JAVA.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant