New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module tests unnecessary strict mode #17

Open

rhuanjl opened this issue Oct 21, 2018 · 1 comment · May be fixed by #25

Assignees

rhuanjl commented Oct 21, 2018

As module code is always treated as strict mode code (https://tc39.github.io/ecma262/#sec-strict-mode-code) it is unnecessary to emit strict and non-strict versions of tests that are to be run as module code.

This results in longer running times and doubling the failure/pass counts for these tests for no purpose.

I think this could be updated by revising create-scenarios.js to check for test.attrs.flags.module.

adrianheine commented Oct 21, 2018

I'm in favor of this! Do you want to prepare a PR?

rwaldron self-assigned this

devsnek linked a pull request

that will close this issue

don't create multiple scenarios from module code #25

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment