Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement error handling - data source and parsing problem #69

Open
bobleesj opened this issue Nov 10, 2024 · 0 comments
Open

Implement error handling - data source and parsing problem #69

bobleesj opened this issue Nov 10, 2024 · 0 comments

Comments

@bobleesj
Copy link
Owner

bobleesj commented Nov 10, 2024

The following is a technical comment by one of the JOSS reviewers.

Error handling for 1) .cif files that do not contain specific attributes 2) invalid input file.


Just a few of final minor points:

  • ... (omitted)
  • ... (omitted)
  • I tried some more random CIF files from CSD/ICSD/MP etc. and all now work without any errors (:confetti_ball:), but some functionality that I expected to work did not. For example, in cases where the CIF only provides chemical_formula_sum and not chemical_formula_structural, the histogram generation for an formula/structure etc. for the ensemble fails. Similarly, when trying to generate polyhedra for these CIFs, the program hangs in cases where invalid input is provided (i.e., not providing a label). You could say these are either user errors or data source errors, but I think for a package aimed at non-specialists it would be helpful to provide a clear error message and fail early in cases where this info is missing. I don't see this as blocking for the paper.

Originally posted by @ml-evs in openjournals/joss-reviews#7205 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant