Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goat: bump up or remove timeout for "goat repo export" #896

Closed
mackuba opened this issue Jan 2, 2025 · 1 comment · Fixed by #902
Closed

goat: bump up or remove timeout for "goat repo export" #896

mackuba opened this issue Jan 2, 2025 · 1 comment · Fixed by #902
Assignees

Comments

@mackuba
Copy link

mackuba commented Jan 2, 2025

I tried to download my repo as a .car file using "goat repo export" yesterday. I was getting this error:

error: reading response body: net/http: request canceled (Client.Timeout or context cancellation while reading body)

or:

error: reading response body: context deadline exceeded (Client.Timeout or context cancellation while reading body)

curl was downloading the repo just fine from https://amanita.us-east.host.bsky.network/xrpc/com.atproto.sync.getRepo?repo=did:plc:oio4hkxaop4ao4wz2pp3f4cr (44.8 MB, in ~34 seconds).

It turns out that there's a default download time limit of 30s applied to all requests, set in https://github.com/bluesky-social/indigo/blob/main/util/http.go#L57. When I increased it to 90 seconds, the export worked fine.

I think this should be increased at least for that one getRepo call (in export and in the migrate task) to at least a few minutes, or just dropped completely. As it is, it will be causing problems for people during the account migration, if more people start migrating who have older accounts with a large post history, running over a slow network, with a bad connection to the Bluesky PDS (e.g. AU/NZ folks), and so on.

@bnewbold
Copy link
Collaborator

bnewbold commented Jan 6, 2025

make sense, will do!

@bnewbold bnewbold self-assigned this Jan 6, 2025
bnewbold added a commit that referenced this issue Jan 7, 2025
Closes: #896

Suspect repo exports to crop up in other places, but can start with this
here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants