Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xrpc-server] Quiet websocket subscriptions time out #3253

Open
hugeblank opened this issue Dec 17, 2024 · 0 comments
Open

[xrpc-server] Quiet websocket subscriptions time out #3253

hugeblank opened this issue Dec 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@hugeblank
Copy link

Describe the bug

I have a cursorless subscription that doesn't have a high throughput like the firehose and as a result can go quiet for several minutes at a time. During that time the websocket closes meaning I have to reconnect, losing out on events. I'd like to not have to implement a cursor, nor do I really like having to constantly reconnect on closing. I would much rather the websocket ping/pong be properly handled.

To Reproduce

Steps to reproduce the behavior:

  1. Create a subscription XRPC endpoint using the package. Consider hooking it up to something that produces an event every 2-5 minutes or so.
  2. Create a client that subscribes to the endpoint. Monitor for closing and messages.

It's more likely that the socket will close before the message comes through.

Expected behavior

The xrpc-server package should be sending pings every 20 seconds or so to connected clients.

Details

  • Operating system: 6.12.1-arch1-1
  • Node version: 23.4.0
@hugeblank hugeblank added the bug Something isn't working label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant